-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Stabilize slice_as_chunks
library feature
#139656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
This comment has been minimized.
This comment has been minimized.
1f3dfae
to
6cfdd53
Compare
The Miri subtree was changed cc @rust-lang/miri |
@rust-lang/libs-api I wanted to drop you a ping because there has been a reasonable amount of discussion during the FCP, so if you want me to hold off this for a bit to give you discussion time, let me know. (I haven't seen any indication from comments that you've changed your minds, but it might just not have made it into the thread.) |
Aye yeah, I'm still good with this. But given the discussion, holding for a second from another libs-api member seems prudent. |
LGTM as well. Thank you. We have talked about this feature across at least a half dozen library API team meetings and not diverged from favoring this design. |
@@ -1314,7 +1314,6 @@ impl<T> [T] { | |||
/// # Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the section above (which I cannot comment because it is too far from the diff) we need to strike "This check will most probably get changed to a compile time error before this method gets stabilized."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, that had even been mentioned in #74985 (comment) and I forgot.
Did a pass over the docs to fix that bit, elaborate on the resulting lengths, and also add a cross-references between these methods and as_flattened(_mut)
.
@rustbot ready
Also mention them from `as_flattened(_mut)`.
Draft as this needs #139163 to land first.FCP: #74985 (comment)
Methods being stabilized are:
(FCP's not done quite yet, but will in another day if I'm counting right.)FCP Complete: #74985 (comment)