Delegate to inner vec::IntoIter from env::ArgsOs
#139847
Open
+199
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delegate from `env::ArgsOs` to any methods which `vec::IntoIter` provides in traits. Since `env::ArgsOs` performs UTF-8 validation, it cannot benefit from this, as even skipped args should still be validated. Add `#[inline]` for any methods which simply wrap the inner iterator.
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
thaliaarchi
force-pushed
the
args/delegate-iter
branch
2 times, most recently
from
3a60980 to
b63849b
Compare
thaliaarchi
added a commit
to thaliaarchi/rust
that referenced
this pull request
Apr 15, 2025
The zkVM implementation of `env::ArgsOs` reports the full length even after having iterated once, which is incorrect. Instead, use a double cursor approach which works out to be simpler. Also, implement more iterator methods like the other platforms in rust-lang#139847.
thaliaarchi
added a commit
to thaliaarchi/rust
that referenced
this pull request
Apr 15, 2025
The zkVM implementation of `env::ArgsOs` incorrectly reports the full length even after having iterated. Instead, use a range approach which works out to be simpler. Also, implement more iterator methods like the other platforms in rust-lang#139847.
thaliaarchi
added a commit
to thaliaarchi/rust
that referenced
this pull request
Apr 15, 2025
The zkVM implementation of `env::ArgsOs` incorrectly reports the full length even after having iterated. Instead, use a range approach which works out to be simpler. Also, implement more iterator methods like the other platforms in rust-lang#139847.
thaliaarchi
force-pushed
the
args/delegate-iter
branch
from
b63849b to
13e6873
Compare
|
☔ The latest upstream changes (presumably #140282) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegate from
env::ArgsOsto any methods whichvec::IntoIterprovides in traits. Sinceenv::ArgsOsperforms UTF-8 validation, it cannot benefit from this, as even skipped args should still be validated. Add#[inline]for any methods which simply wrap the inner iterator.