Improve diagnostics for usage of qualified paths within tuple struct exprs/pats #140370
+327
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Better explain what the test tests 2. Test slightly more cases
rustbot
added
S-waiting-on-review
1. Fix "expected" and the note for the pattern case 2. Add suggestions
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
unqualified
branch
from
82f1d10 to
8f765fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For patterns the old diagnostic was just incorrect, but I also added machine applicable suggestions.
For context, this special cases errors for
<T as Trait>::Assoc(..)patterns and expressions (latter is just a call). Tuple struct patterns and expressions both live in the value namespace, so they are not forwarded through associated types.r? @jdonszelmann
cc @petrochenkov in #80080 (comment) you were wondering why it doesn't work for types, that's why — tuple patterns are resolved in the value namespace.