Skip to content

ci: split powerpc64le-linux job #141042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: split powerpc64le-linux job #141042

wants to merge 1 commit into from
+63 −13

Conversation

marcoieni
Copy link
Member

Split this job to make it faster and remove the large runner.

r? @Kobzol

try-job: dist-powerpc64le-linux-*

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 15, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge of rust-lang#141042 - marcoieni:split-dist-powerpc64le-lin…
0a3d50e 
…ux, r=<try>

ci: split powerpc64le-linux job

try-job: `dist-powerpc64le-linux-*`
@bors
Copy link
Collaborator

bors commented May 15, 2025

⌛ Trying commit 70f01c1 with merge 0a3d50e...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented May 15, 2025

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 15, 2025
@marcoieni marcoieni force-pushed the split-dist-powerpc64le-linux branch from 70f01c1 to fd0bff5 Compare May 16, 2025 09:26
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
@bors
Auto merge of rust-lang#141042 - marcoieni:split-dist-powerpc64le-lin…
328415a 
…ux, r=<try>

ci: split powerpc64le-linux job

try-job: `dist-powerpc64le-linux-*`
@bors
Copy link
Collaborator

bors commented May 16, 2025

⌛ Trying commit fd0bff5 with merge 328415a...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented May 16, 2025

💔 Test failed - checks-actions

@marcoieni marcoieni force-pushed the split-dist-powerpc64le-linux branch from fd0bff5 to 103a86a Compare May 16, 2025 09:35
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
@bors
Auto merge of rust-lang#141042 - marcoieni:split-dist-powerpc64le-lin…
cfa3161 
…ux, r=<try>

ci: split powerpc64le-linux job

try-job: `dist-powerpc64le-linux-*`
@bors
Copy link
Collaborator

bors commented May 16, 2025

⌛ Trying commit 103a86a with merge cfa3161...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented May 16, 2025

💔 Test failed - checks-actions

@marcoieni marcoieni force-pushed the split-dist-powerpc64le-linux branch 2 times, most recently from 711f255 to 8de11dd Compare May 18, 2025 09:08
marcoieni
marcoieni commented May 18, 2025
View reviewed changes
src/ci/docker/host-x86_64/dist-powerpc64le-linux-musl/powerpc64le-unknown-linux-musl.defconfig Outdated
Comment on lines 13 to 14
CT_LIBC_MUSL=y
CT_MUSL_V_1_2_3=y
Copy link
Member Author

@marcoieni marcoieni May 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were the same for the -gnu build so I kept them.
Should this defconfig be different for the two jobs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it doesn't matter much, as the -gnu build shouldn't be using MUSL at all. We could probably delete this (the MUSL config options) from the GNU config.

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Trying commit 8de11dd with merge c9a1722...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@bors
Auto merge of rust-lang#141042 - marcoieni:split-dist-powerpc64le-lin…
c9a1722 
…ux, r=<try>

ci: split powerpc64le-linux job

try-job: `dist-powerpc64le-linux-*`
@bors
Copy link
Collaborator

bors commented May 18, 2025

☀️ Try build successful - checks-actions
Build commit: c9a1722 (c9a1722660c026d01d7a2c7915fed65f7fb4ff97)

@marcoieni
Copy link
Member Author

marcoieni commented May 18, 2025 •
edited
Loading

Reviewers, please check the difference with the Dockerfiles (before and after this PR).

Timings look good
image

@marcoieni marcoieni marked this pull request as ready for review May 18, 2025 14:52
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2025
@marcoieni
Copy link
Member Author

@rustbot ready

Kobzol
Kobzol reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few nits, but otherwise you can r=me.

src/ci/docker/host-x86_64/dist-powerpc64le-linux-musl/powerpc64le-unknown-linux-musl.defconfig Outdated
Comment on lines 13 to 14
CT_LIBC_MUSL=y
CT_MUSL_V_1_2_3=y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it doesn't matter much, as the -gnu build shouldn't be using MUSL at all. We could probably delete this (the MUSL config options) from the GNU config.

@marcoieni marcoieni force-pushed the split-dist-powerpc64le-linux branch from 8de11dd to 4c37d97 Compare May 20, 2025 10:02
@marcoieni
Copy link
Member Author

@bors try

This was referenced May 20, 2025
Closed
Open
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 20, 2025

⌛ Trying commit 4c37d97 with merge 5ccc94d...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
@bors
Auto merge of rust-lang#141042 - marcoieni:split-dist-powerpc64le-lin…
5ccc94d 
…ux, r=<try>

ci: split powerpc64le-linux job

try-job: `dist-powerpc64le-linux-*`
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented May 20, 2025

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2025
@marcoieni marcoieni force-pushed the split-dist-powerpc64le-linux branch from 4c37d97 to a8173fc Compare May 20, 2025 13:16
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 20, 2025

⌛ Trying commit a8173fc with merge 10f83d9...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
@bors
Auto merge of rust-lang#141042 - marcoieni:split-dist-powerpc64le-lin…
10f83d9 
…ux, r=<try>

ci: split powerpc64le-linux job

try-job: `dist-powerpc64le-linux-*`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcoieni @bors @rust-log-analyzer @Kobzol @rustbot