Add T: PartialEq bounds to derived StructuralPartialEq impls.#156807
Draft
kpreid wants to merge 1 commit into
Draft
Add T: PartialEq bounds to derived StructuralPartialEq impls.#156807kpreid wants to merge 1 commit into
T: PartialEq bounds to derived StructuralPartialEq impls.#156807kpreid wants to merge 1 commit into
Conversation
Contributor
Author
|
This PR is probably less correct than the just-posted #156809, because the documentation of Currently waiting on an answer to my question about a route to to fixing the diagnostics. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Adding const X: Option<Box<()>> = None;
fn main() {
if let X = X {}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147714.
Currently has a severe regression in diagnostic quality — suggesting
derive(PartialEq)on the type that already has that derive — apparently because the diagnostic logic effectively checks whetherStructuralPartialEqexists as a proxy for whether the type has the derive. I don’t yet know how to solve that problem.This is a breaking change to fix a bug, so it will need a crater run if it is to be done at all.