Rollup of 7 pull requests#158884
Closed
JonathanBrouwer wants to merge 16 commits into
Closed
Conversation
Use correct typing mode in mir building for the next solver Previously, we used typing env `non_body_analysis` when building MIR body. This is wrong because we're in a body and should reveal opaque types defined in this scope. Fixes rust-lang#158439 Fixes rust-lang#158429 r? lcnr or anyone familiar with typing modes.
…Kobzol Update the rustc_perf submodule I hope this is a thing that's ok to do, I never update submodules but this one seems to be 8 months old and we got some new benchmarks in the meantime. r? @Kobzol
…r=lcnr Prevent rustdoc auto-trait ICEs with `-Znext-solver=globally` - Ensure rustdoc with `-Znext-solver=globally` does not ICE. r? @lcnr
Instatiate binder instead of skipping when suggesting function arg error Fixes rust-lang#158317 r? lcnr
Avoid infinite recursion when trying to build valtrees for self-referential consts This PR adds cycle detection to `const_to_valtree_inner` by using a tricolor DFS, so self-referential statics in pats don't cause valtree construction to recurse infinitely. Instead, we now return a new `ValTreeCreationError::CyclicConst`, similar to the current `InvalidConst` and `NodesOverflow` variants. fixes rust-lang#144719
…arantees, r=clarfonthey Document blocking guarantees for `std::sync` Per rust-lang#157728, this PR documents how exactly functions/methods in `std::mpsc` (and `mpmc`) block. Copied from the issue: > For the wasm part of this specifically, yes, using a mutex anywhere is basically forbidden on the main thread in browsers. Personally I don't think it's reasonable to expect the standard library to use zero mutexes on wasm and make absolutely everything lock-free. This is a consequence of browsers and not something Rust can "just" fix. Basically I would not recommend changing the implementation and instead leaving it as-is. I'll note that there's a long and storied history of blocking-the-main-thread-with-wasm-threads in the browser, and I'm not putting in all the context here. > > \- alexcrichton (P.S. documentation seems to be line wrapped but doesn't have a consistent wrapping width? I tried to match the surrounding style as best as I could; let me know if there's something better I should've done) Fixes rust-lang#157728
rewrite `Align::max_for_target` in a more obvious way r? scottmcm The old version was just as correct, and arguably this doesn't matter, but oh well... Following the confusion in https://github.com/rust-lang/rust/pull/152929/changes#r2836568710.
rustbot
added
A-tidy
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 6, 2026
Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
Contributor
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Znext-solver=globally#158346 (Prevent rustdoc auto-trait ICEs with-Znext-solver=globally)std::sync#158679 (Document blocking guarantees forstd::sync)Align::max_for_targetin a more obvious way #158867 (rewriteAlign::max_for_targetin a more obvious way)r? @ghost
Create a similar rollup