cmse: clear variant-dependent padding#159466
Open
folkertdev wants to merge 5 commits into
Open
Conversation
folkertdev
added
F-cmse_nonsecure_entry
rustbot
added
S-waiting-on-review
Member
|
maybe add a check that |
Contributor
Author
|
The lint is in #147697 (but needs updating now). It triggers when |
RalfJung
reviewed
Jul 18, 2026
RalfJung
reviewed
Jul 18, 2026
RalfJung
reviewed
Jul 18, 2026
RalfJung
reviewed
Jul 18, 2026
Member
There was a problem hiding this comment.
I can't see any test here covering nested enums?
folkertdev
force-pushed
the
clear-variant-dependent-padding
branch
from
July 18, 2026 10:46
6e5759f to
0fe4afc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #81391
tracking issue: #75835
Since #157397 we clear variant-independent padding, bytes that are padding for all valid values of the type. This PR extends that idea to also clear variant-dependent padding, where we have to check what variant a (nested) enum has to determine which bytes are padding so we can clear them.
With these changes the lint from #147697 can lint on just
unions.r? @davidtwco
cc @RalfJung @Jules-Bertholet