Skip to content

PassWrapper: adapt to LLVM reading exception model from module flag - #162903

Open
durin42 wants to merge 1 commit into
rust-lang:mainfrom
durin42:llvm-24-exception-model-flag
Open

PassWrapper: adapt to LLVM reading exception model from module flag#162903
durin42 wants to merge 1 commit into
rust-lang:mainfrom
durin42:llvm-24-exception-model-flag

Conversation

@durin42

@durin42 durin42 commented Sep 17, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

As with #162822, LLVM 24 is now reading exception model from the module flags instead of taking it as an extra parameter here.

@rustbot label: +llvm-main

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 17, 2026
@rustbot

rustbot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @cuviper

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Sep 17, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@durin42
durin42 force-pushed the llvm-24-exception-model-flag branch 2 times, most recently from 2c671c1 to a293337 Compare September 17, 2026 14:09
cuviper
cuviper reviewed Sep 17, 2026
View reviewed changes
Comment thread compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp Outdated
@durin42
durin42 force-pushed the llvm-24-exception-model-flag branch from a293337 to e34a800 Compare September 17, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuviper cuviper cuviper left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@cuviper cuviper

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@durin42 @rustbot @rust-log-analyzer @cuviper