Skip to content

Destabilize VaArgSafe - #162909

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
maxdexh:claw-back-va-arg-safe
Sep 18, 2026
Merged

Destabilize VaArgSafe#162909
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
maxdexh:claw-back-va-arg-safe

Conversation

@maxdexh

@maxdexh maxdexh commented Sep 17, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Destabilizes VaArgSafe before 1.99 hits stable, due to open concerns about whether references should implement the trait, which would be breaking to add later.

See discussion on Zulip.

Tracking issue: #162911

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 17, 2026
@maxdexh
maxdexh force-pushed the claw-back-va-arg-safe branch from b90e121 to 69f7122 Compare September 17, 2026 15:11
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 17, 2026
@maxdexh
maxdexh force-pushed the claw-back-va-arg-safe branch from 69f7122 to 04f2f84 Compare September 17, 2026 15:14
folkertdev
folkertdev reviewed Sep 17, 2026
View reviewed changes
Comment thread library/core/src/ffi/va_list.rs Outdated
@maxdexh maxdexh mentioned this pull request Sep 17, 2026
Open
6 tasks
@maxdexh
maxdexh force-pushed the claw-back-va-arg-safe branch from 04f2f84 to d0cbd07 Compare September 17, 2026 15:37
@maxdexh maxdexh changed the title Unstabilize VaArgSafe Destabilize VaArgSafe Sep 17, 2026
@maxdexh
maxdexh marked this pull request as ready for review September 17, 2026 15:40
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 17, 2026
@rustbot

rustbot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 6 candidates

@theemathas theemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 17, 2026
@theemathas theemathas mentioned this pull request Sep 17, 2026
Open
@clarfonthey

clarfonthey commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@bors try

rust-bors Bot pushed a commit that referenced this pull request Sep 17, 2026
@bors
Auto merge of #162909 - maxdexh:claw-back-va-arg-safe, r=<try>
6d23f9d 
Destabilize `VaArgSafe`
@rust-bors

This comment has been minimized.

Sign in to view
@clarfonthey

clarfonthey commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Due to time sensitivity:

@bors r+ rollup=never p=1 note="Backport"

@rust-bors

rust-bors Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d0cbd07 has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2026
@rustbot

rustbot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

beta backport approved as per libs team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 17, 2026
@rust-bors

rust-bors Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 6d23f9d (6d23f9df605009c63f34d1339f4e4f53cdbbfe19)
Base parent: c999cef (c999cef531ea9059e189e82fe0e82c5daf249bc9)

steffahn
steffahn reviewed Sep 17, 2026
View reviewed changes
Comment thread library/core/src/ffi/va_list.rs Outdated
@maxdexh
maxdexh force-pushed the claw-back-va-arg-safe branch from d0cbd07 to 5e3ad00 Compare September 17, 2026 19:03
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2026
@rust-bors

rust-bors Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

⚠️ A new commit 5e3ad0017d8b3e193c10ab6230369aead2e9ea69 was pushed.

This pull request was unapproved.

@maxdexh

maxdexh commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

We're waiting in the queue on clippy subtree update for a few hours anyway ^^

@clarfonthey

clarfonthey commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 17, 2026
@bors
Auto merge of #162909 - maxdexh:claw-back-va-arg-safe, r=<try>
16d346e 
Destabilize `VaArgSafe`
@rust-bors

rust-bors Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 16d346e (16d346ee80019147b2e813369f9c7f1ec6311029)
Base parent: 76af58f (76af58f665c5cd76672e64ca118efbb0101fb224)

@clarfonthey

clarfonthey commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup=never p=1 note="Backport"

@rust-bors

rust-bors Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5e3ad00 has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 17, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 18, 2026
@rust-bors

rust-bors Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: clarfonthey
Duration: 3h 17m 19s
Pushing ed30c2c to main...

@rust-bors
rust-bors Bot merged commit ed30c2c into rust-lang:main Sep 18, 2026
15 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 18, 2026
@rust-bors rust-bors Bot mentioned this pull request Sep 18, 2026
Open
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 330d317 (parent) -> ed30c2c (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ed30c2ce5e06cc4b9ab31f9a3dd20635987a8d7a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-msvc-ext1: 1h 23m -> 2h 24m (+73.2%)
  2. test-i686-gnu-1: 1h 20m -> 2h 14m (+67.3%)
  3. test-x86_64-gnu-llvm-21-1: 35m 26s -> 54m 58s (+55.1%)
  4. dist-x86_64-musl: 1h 37m -> 2h 23m (+47.8%)
  5. dist-arm-linux-musl: 1h 16m -> 1h 46m (+37.9%)
  6. dist-loongarch64-linux: 2h 9m -> 1h 23m (-35.3%)
  7. test-x86_64-gnu-llvm-21-2: 1h 40m -> 1h 5m (-34.4%)
  8. test-i686-gnu-2: 1h 12m -> 1h 37m (+34.2%)
  9. dist-x86_64-mingw: 2h 8m -> 2h 49m (+31.4%)
  10. test-x86_64-rust-for-linux: 42m 49s -> 56m 4s (+30.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffahn steffahn steffahn left review comments
@folkertdev folkertdev folkertdev left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

7 participants

@maxdexh @rustbot @clarfonthey @steffahn @folkertdev @Mark-Simulacrum @theemathas