Conversation
rustbot
added
A-rustdoc-json
Member
Author
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
[WIP] rustdoc: Improve `ItemKind`
fmease
force-pushed
the
rustdoc-better-item-kinds
branch
from
September 17, 2026 17:36
75c7db0 to
b15adfe
Compare
Moreover, rename `Function` to `Fn`, `*Method` to `*AssocFn`, `*Type` to `*Ty`, `Constant` to `Const` & `Macro` to `DeclMacro`.
…ssocConst` I had to modify several HTML rendering routines because parameter `parent: ItemType` of fn `render_assoc_item` didn't always refer to the parent container (impl vs trait) since it was actually misused to control the styling (!), namely the indentation & the look of the where-clause, but now with `ProvidedAssocConst` & `ImplAssocConst` merged I needed to know the actual container to determine `AssocConstValue`. `render_assoc_item` previously only used the `parent` param to determine the indentation & `assoc_method` used it to determine the indentation & the style of the where-clause (see enum `Ending`; complete misnomer!). That led to `item_trait` (for rendering trait pages) literally passing `ItemType::Impl` for the "docs section" (as contrasted with the "code block") to avoid indenting it. To untangle this, I forced the callers of `render_assoc_item` to specify the indentation & the where-clause styling via new parameters. *Moreover*, as alluded to above, only `assoc_method` made the where-clause styling (`Ending`) dependent on the context, not however `assoc_const` or `assoc_ty`! I've fixed that here to avoid making the parameter list of `render_assoc_item` even longer & since it makes them consistent (thereby fixing the remaining issues reported in RUST-112901).
FIXME: Better names & types.
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (77d2154): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.8%, secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 500.132s -> 501.928s (0.36%) |
rustbot
added
perf-regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Description.
Addresses #112901 (comment) & thereby fixes #112901.
(No LLM was or will be used by me during the entire creation process of this PR)