Skip to content

An assortment of polonius tweaks - #162922

Open
lqd wants to merge 4 commits into
rust-lang:mainfrom
lqd:assorted-delights
Open

An assortment of polonius tweaks#162922
lqd wants to merge 4 commits into
rust-lang:mainfrom
lqd:assorted-delights

Conversation

@lqd

@lqd lqd commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

As discussed on zulip, r? @jackh726 this contains a couple tweaks:

  • fixes the variance recording to be done at the expected two places instead of three (it should be idempotent, but as we saw with unexpected variance, better safe than sorry)
  • cleans it up to also match with the deferred liveness work
  • starts adding some features from my polonius mir dump prototypes (here, just some simple navigation QoL additions)
  • improves the visuals slightly again (details in the commits; but mostly as you can see in this example and fixed here, some lines in the MIR dump can be huge and that made the viewport scroll, etc)

lqd added 4 commits September 17, 2026 21:08
@lqd
fix and clean up variance recording in liveness
cba3954
@lqd
simplify make_all_regions_live
8a699c7 
there's no need to wrap the value at runtime to visit it
@lqd
add quick links
942dcc9
@lqd
more visual improvements
ada6d89 
- fix margins
- ensure the MIR code wraps instead of needing scrollbars
- defocus the trace suffixes
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 17, 2026
@jackh726

jackh726 commented Sep 17, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ada6d89 has been approved by jackh726

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726 jackh726

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lqd @jackh726 @rustbot