Use niche length type for strlen to guarantee isize::MAX bound - #162930
Open
clarfonthey wants to merge 1 commit into
Open
clarfonthey wants to merge 1 commit into
clarfonthey wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
clarfonthey
force-pushed
the
strlen-is-bounded
branch
from
September 17, 2026 21:53
ebb05a8 to
2605c8d
Compare
clarfonthey
commented
Sep 17, 2026
| unsafe { strlen(s) } | ||
| // SAFETY: Outer caller has provided a pointer to a valid C string, | ||
| // and its length is within bounds. | ||
| unsafe { UsizeNoHighBitMinusOne::new_unchecked(strlen(s)) } |
Contributor
Author
There was a problem hiding this comment.
Note: I decided to do this (which is just a transmute) instead of making strlen explicitly return this type, since it felt apt to include this as part of this particular method's unsafe precondition instead of trying to assume that would hold for the C version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #162912.
r? hanna-kruppe
cc @Darksonn