Repository navigation
Inline fold operations for Chain and Map, for performance - #163775
joshtriplett wants to merge 1 commit into
Conversation
|
r? @Darksonn rustbot has assigned @Darksonn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Inline fold operations for Chain and Map, for performance
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (ddc0f5f): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -5.7%, secondary 1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.9%, secondary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 490.682s -> 490.616s (-0.01%) |
|
Rerolling due to conference travel. @rustbot reroll |
|
Based on the performance data, this seems to provide some pretty sizable wins. |
|
Closing in favor of #163845 which includes these and several more. |
These show up in hot paths; let's see if this helps.