Repository navigation
[beta] backports - #164233
Open
cuviper wants to merge 14 commits into
Open
[beta] backports#164233cuviper wants to merge 14 commits into
cuviper wants to merge 14 commits into
Conversation
Co-authored-by: Philip Sampaio <philip.sampaio@gmail.com> (cherry picked from commit e9a87d0)
The ICE was caused because the code assumed the import_ids would always be the same for all candidates, but it's not true. Sometimes the candidate is ambiguous with import_ids to be logged and sometimes the candidate is not ambigous and does not have the ids. Mixing the two (flag = true, without import_ids) ICEs. Co-authored-by: Philip Sampaio <philip.sampaio@gmail.com> (cherry picked from commit 109c917)
(cherry picked from commit 9379da6)
(cherry picked from commit 3631ff3)
…adjusted never type (cherry picked from commit ceee44b)
(cherry picked from commit f3b6502)
(cherry picked from commit a7709ec)
(cherry picked from commit 87ec21a)
(cherry picked from commit e1a95eb)
(cherry picked from commit 294ff0f)
(cherry picked from commit a0f1885)
(cherry picked from commit 5d6aec6)
(cherry picked from commit 94fa86c)
(cherry picked from commit 7b151cf)
rustbot
added
A-LLVM
This comment was marked as resolved.
This comment was marked as resolved.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Globalin the docs ofSystemDon't imply incorrect things aboutGlobalin the docs ofSystem#163342Selfin constructor paths again use the type name instead ofSelfin constructor paths again #163863synchronizationimport lib to windows-gnullvm dist Addsynchronizationimport lib to windows-gnullvm dist #163933r? me