Improve placement of use suggestions
#43929
Conversation
There was a problem hiding this comment.
Love it! The new locations are exactly where they should be. The only wart I see is that by applying these suggestions without any smarts the resulting output would be the following:
use a::A;
struct S;I don't think we should change the compiler output, I think clients could perform local reformatting to comply with rustfmt instead.
src/librustc_resolve/lib.rs
Outdated
| let def_id = this.current_module.normal_ancestor_id; | ||
| let node_id = this.definitions.as_local_node_id(def_id).unwrap(); | ||
| let better = def.is_some(); | ||
| this.use_injections.push(UseError{ err, candidates, node_id, better }); |
There was a problem hiding this comment.
Space between UseError and {?
| _: Span, | ||
| _: &[ast::Attribute], | ||
| node_id: NodeId, | ||
| ) { |
There was a problem hiding this comment.
Isn't the following slightly easier to follow?
fn visit_mod(&mut self,
module: &'tcx ast::Mod,
_: Span,
_: &[ast::Attribute],
node_id: NodeId) {There was a problem hiding this comment.
Rustfmt has my version as the new style and I prefer it, too, but I can change it to the other style to fit more into what's still more prominent in rustc.
I'm confused... so you want the final output to be |
|
I'd want the final output to be use a::A;
struct S;But wouldn't change rustc for it, as it makes the cli output worse. |
Oh I already have a hack that makes sure the cli is fine ;) Adding another newline to the suggestion output in case the following item is not a |
|
@bors: r+ |
|
📌 Commit 8f56322 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
r? @nrc
cc @estebank @Mark-Simulacrum
fixes #42835
fixes #42548
fixes #43769