-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add repeat method on slice #48999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repeat method on slice #48999
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
#![feature(repeat_generic_slice)] | ||
|
||
fn main() { | ||
assert_eq!([1, 2].repeat(2), vec![1, 2, 1, 2]); | ||
assert_eq!([1, 2, 3, 4].repeat(0), vec![]); | ||
assert_eq!([1, 2, 3, 4].repeat(1), vec![1, 2, 3, 4]); | ||
assert_eq!([1, 2, 3, 4].repeat(3), | ||
vec![1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4]); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1722,6 +1722,77 @@ impl<T> [T] { | |
// NB see hack module in this file | ||
hack::into_vec(self) | ||
} | ||
|
||
/// Creates a vector by repeating a slice `n` times. | ||
/// | ||
/// # Examples | ||
/// | ||
/// Basic usage: | ||
/// | ||
/// ``` | ||
/// #![feature(repeat_generic_slice)] | ||
/// | ||
/// fn main() { | ||
/// assert_eq!([1, 2].repeat(3), vec![1, 2, 1, 2, 1, 2]); | ||
/// } | ||
/// ``` | ||
#[unstable(feature = "repeat_generic_slice", | ||
reason = "it's on str, why not on slice?", | ||
issue = "48784")] | ||
pub fn repeat(&self, n: usize) -> Vec<T> where T: Copy { | ||
if n == 0 { | ||
return Vec::new(); | ||
} | ||
|
||
// If `n` is larger than zero, it can be split as | ||
// `n = 2^expn + rem (2^expn > rem, expn >= 0, rem >= 0)`. | ||
// `2^expn` is the number represented by the leftmost '1' bit of `n`, | ||
// and `rem` is the remaining part of `n`. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It took me a few minutes to figure out why this function is so complex - maybe add a comment that explicitly explains that its trying to minimize the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just moved the code around, didn't modify it. It's exactly like it was before in |
||
// Using `Vec` to access `set_len()`. | ||
let mut buf = Vec::with_capacity(self.len() * n); | ||
|
||
// `2^expn` repetition is done by doubling `buf` `expn`-times. | ||
buf.extend(self); | ||
{ | ||
let mut m = n >> 1; | ||
// If `m > 0`, there are remaining bits up to the leftmost '1'. | ||
while m > 0 { | ||
// `buf.extend(buf)`: | ||
unsafe { | ||
ptr::copy_nonoverlapping( | ||
buf.as_ptr(), | ||
(buf.as_mut_ptr() as *mut T).add(buf.len()), | ||
buf.len(), | ||
); | ||
// `buf` has capacity of `self.len() * n`. | ||
let buf_len = buf.len(); | ||
buf.set_len(buf_len * 2); | ||
} | ||
|
||
m >>= 1; | ||
} | ||
} | ||
|
||
// `rem` (`= n - 2^expn`) repetition is done by copying | ||
// first `rem` repetitions from `buf` itself. | ||
let rem_len = self.len() * n - buf.len(); // `self.len() * rem` | ||
if rem_len > 0 { | ||
// `buf.extend(buf[0 .. rem_len])`: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm, why is the code here not just literally There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because you cannot have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, of course. I somehow forgot about the borrow checker for a minute there, too much C++ recently... |
||
unsafe { | ||
// This is non-overlapping since `2^expn > rem`. | ||
ptr::copy_nonoverlapping( | ||
buf.as_ptr(), | ||
(buf.as_mut_ptr() as *mut T).add(buf.len()), | ||
rem_len, | ||
); | ||
// `buf.len() + rem_len` equals to `buf.capacity()` (`= self.len() * n`). | ||
let buf_cap = buf.capacity(); | ||
buf.set_len(buf_cap); | ||
} | ||
} | ||
buf | ||
} | ||
} | ||
|
||
#[lang = "slice_u8"] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.