Skip to content

Add impls for powers of 2 length arrays. #51954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

richard-uk1
Copy link
Contributor

It would be really nice if there could be more array impls. I know that const generics are coming, but this would allow me to avoid having to write a lot of these impls myself, which would save me a lot of time, and make the eventual conversion to const generics a zero-work job for me. :)

I'm just submitting this as a PR because the change is so small, it's the same amount of effort as writing an issue.

It would be really nice if there could be more array impls. I know that const generics are coming, but this would allow me to avoid having to write a lot of these impls myself, which would save me a lot of time, and make the eventual conversion to const generics a zero-work job for me. :)
@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2018
@alex
Copy link
Member

alex commented Jul 1, 2018

See also #51318 :-)

@oli-obk oli-obk added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 1, 2018
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2018
@richard-uk1
Copy link
Contributor Author

I'm tempted to close this since I'm happy to just start using const generics on nightly when they land.

Totally more excited about them than rust 2018 :)

@richard-uk1
Copy link
Contributor Author

I've made a crate to implement the traits I need for newtypes (basically by copying the macro in the rust source). It's on crates.io. So for me I'm happy using this because it means I can continue to support stable, but I'll leave this open in case someone else wants, I don't need it any more though.

@cramertj
Copy link
Member

cramertj commented Jul 2, 2018

cc @rust-lang/libs -- what's the current policy on extending these array impls?

@alexcrichton
Copy link
Member

Historically the libs team has decided to not change what we have, although it's been awhile so we can revisit this decision during the next triage meeting as well.

@alexcrichton
Copy link
Member

alexcrichton commented Jul 12, 2018

Ok the libs team discussed this yesterday and have reached the same conclusion as before, so I'm going to close this. Thanks regardless though for the PR @derekdreery !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants