rustc: Stabilize #[wasm_import_module] #52441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This commit stabilizes the `#[wasm_import_module]` attribute. Tracked by rust-lang#52090 this issue can be attached to foreign modules (`extern { ... }` blocks) and is used to configured the module name that the imports are listed with. The WebAssembly specification indicates two utf-8 names are associated with all imported items, one for the module the item comes from and one for the item itself. The item itself is configurable in Rust via its identifier or `#[link_name = "..."]`, but the module name was previously not configurable and defaulted to `"env"`. This commit ensures that this is also configurable. Closes rust-lang#52090
alexcrichton
force-pushed
the
wasm-import-module
branch
from
ab0925f to
75e34ac
Compare
|
Looks like the sentiment in #52090 (comment) was to make it a modifier on |
|
Er argh yes, forgot about that! Thanks for the reminder, I'll make a new PR soon |
|
New PR is at #52445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit stabilizes the
#[wasm_import_module]attribute. Tracked by #52090this issue can be attached to foreign modules (
extern { ... }blocks) and isused to configured the module name that the imports are listed with. The
WebAssembly specification indicates two utf-8 names are associated with all
imported items, one for the module the item comes from and one for the item
itself. The item itself is configurable in Rust via its identifier or
#[link_name = "..."], but the module name was previously not configurable anddefaulted to
"env". This commit ensures that this is also configurable.Closes #52090