-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update cmake, cc and compiler_builtins for VS 2019 support #59799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors: r+ |
📌 Commit d28234b7d4b449f85c0bd2ae9cc3db48f9bdee69 has been approved by |
@bors p=1 so I won't be tempted to uninstall it |
@bors p=10 Raising above rollup todo. |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
@bors r=alexcrichton |
📌 Commit 044a3bfd433cc189b48e411207d0a58f8be4343b has been approved by |
⌛ Testing commit 044a3bfd433cc189b48e411207d0a58f8be4343b with merge 562c19207fc8f40e0cdc55b6b92d25f9928d80c0... |
@bors retry yielding priority to clippy PR |
⌛ Testing commit 044a3bfd433cc189b48e411207d0a58f8be4343b with merge 0540b7bee064d21eac7da9d8ac5c67672083e042... |
@bors retry Yield priority to clippy PR which blocks the beta |
⌛ Testing commit 044a3bfd433cc189b48e411207d0a58f8be4343b with merge a6ab195db1fdeea173d6425e6afb414543d9eaf6... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@alexcrichton Is this a |
Looks like we require a C compiler for wasm32, but we don't appear to use one. Added a fix for that. |
@bors: r+ |
📌 Commit c44ad6a825a6748a19eaf2fb1b42c5eb9a79178c has been approved by |
🌲 The tree is currently closed for pull requests below priority 15, this pull request will be tested once the tree is reopened |
☔ The latest upstream changes (presumably #59810) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors r=alexcrichton |
📌 Commit 7b28ddc has been approved by |
⌛ Testing commit 7b28ddc with merge fd6f22f982ea911432d8f4ace17ca9341f1f058c... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
Update cmake, cc and compiler_builtins for VS 2019 support r? @alexcrichton
☀️ Test successful - checks-travis, status-appveyor |
r? @alexcrichton