-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix a hash collision issue on the const_field
query
#61959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`ByRef` const values have no identity beyond their value, we should not treat them as having identity. The `AllocId` often differed between equal constants, because of the way that the miri-engine evaluates constants.
(rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with nits fixed (if at all)
@bors r=eddyb |
📌 Commit cdf5596 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r=eddyb |
📌 Commit 3dfe017 has been approved by |
⌛ Testing commit 3dfe017 with merge c4b412a2f301811fedf15d8f40c57320db126ad5... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry
|
@bors r=eddyb |
📌 Commit d46a373 has been approved by |
Fix a hash collision issue on the `const_field` query fixes #61530
☀️ Test successful - checks-travis, status-appveyor |
We need commit d46a373b391cb546f5a737fd5009f7733c220531 (rust-lang/rust#61959) to avoid a compiler ICE when using simd builtins.
fixes #61530