Skip to content

Update Clippy #66995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2019
Merged

Update Clippy #66995

merged 1 commit into from
Dec 4, 2019

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Dec 3, 2019

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2019
@Manishearth
Copy link
Member

@bors r+ p=2

@bors
Copy link
Collaborator

bors commented Dec 3, 2019

📌 Commit e158a98 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2019
@bors
Copy link
Collaborator

bors commented Dec 3, 2019

⌛ Testing commit e158a98 with merge 86fd947a112436198408e610053f3ab749dd0670...

@Centril
Copy link
Contributor

Centril commented Dec 3, 2019

@bors retry yielding to r0llup-remake

@bors
Copy link
Collaborator

bors commented Dec 3, 2019

⌛ Testing commit e158a98 with merge 94388df...

bors added a commit that referenced this pull request Dec 3, 2019
@bors
Auto merge of #66995 - flip1995:clippyup, r=Manishearth
94388df 
Update Clippy

Fixes #66989

r? @Manishearth @Centril
@matthiaskrgr
Copy link
Member

Looks like the latest rollup broke clippy again so I guess this can be cancelled... :(

@Manishearth
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2019
@RalfJung
Copy link
Member

RalfJung commented Dec 3, 2019

"r-" just takes it off the queue but doesn't cancel a running job. "retry" does.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2019
@RalfJung
Copy link
Member

RalfJung commented Dec 3, 2019

@bors r- (fixing labels)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2019
@flip1995
Copy link
Member Author

flip1995 commented Dec 4, 2019

Updated Clippy. Ready for another r+

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 4, 2019

📌 Commit 5ce98d3 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 4, 2019
@bors
Copy link
Collaborator

bors commented Dec 4, 2019

⌛ Testing commit 5ce98d3 with merge ff14308...

bors added a commit that referenced this pull request Dec 4, 2019
@bors
Auto merge of #66995 - flip1995:clippyup, r=Manishearth
ff14308 
Update Clippy

Fixes #66989

r? @Manishearth @Centril
@bors
Copy link
Collaborator

bors commented Dec 4, 2019

☀️ Test successful - checks-azure
Approved by: Manishearth
Pushing ff14308 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2019
@bors bors merged commit 5ce98d3 into rust-lang:master Dec 4, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #66995!

Tested on commit ff14308.
Direct link to PR: #66995

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Dec 4, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#66995!
fc3ccaa 
Tested on commit rust-lang/rust@ff14308.
Direct link to PR: <rust-lang/rust#66995>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
@RalfJung RalfJung mentioned this pull request Dec 4, 2019
Open
@flip1995 flip1995 deleted the clippyup branch December 4, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#66982
7 participants
@flip1995 @rust-highfive @Manishearth @bors @Centril @matthiaskrgr @RalfJung