-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rust-demangler tool strips crate disambiguators with < 16 digits #77627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
I did not know we had this in tree and am unsure of what exactly it's used for (I guess I can look). r? @eddyb for now though. |
I added the tool a while back. It supports |
Just FYI... @wesleywiser @tmandry This is the PR to resolve the bug report against AArch64 (though I think the bug isn't really specific to that architecture, and could get triggered on any platform depending on the generated hash value). |
It seems pretty clear now that this is a heuristic to remove disambiguators, even if it's one that's very likely to succeed. That does seem acceptable for the tests we're using it for, but maybe not for everything. I think we should document that it's using a heuristic in the doc comment and help text, just so people know about it before they take on a dependency. @bors delegate+ |
✌️ @richkadel can now approve this pull request |
I'll make the additional changes before submitting to bors. Thanks! |
420ac3c
to
796e6ac
Compare
@bors r=tmandry |
📌 Commit 796e6ac has been approved by |
☀️ Test successful - checks-actions, checks-azure |
Addresses Issue #77615.