-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Do not ICE on generic type mismatch in anonymous const #80278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
src/test/ui/typeck/issue-80062-mismatched-types-anon-const.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// Regression test for issue #80062 | ||
|
||
fn foo<Foo>() -> Foo { todo!() } | ||
|
||
fn bar<T>() { | ||
let _: [u8; foo::<T>()]; | ||
//~^ ERROR the size for values of type `T` cannot be known at compilation time | ||
//~^^ ERROR mismatched types | ||
//~^^^ ERROR the size for values of type `T` cannot be known at compilation time | ||
} | ||
|
||
fn main() {} |
41 changes: 41 additions & 0 deletions
41
src/test/ui/typeck/issue-80062-mismatched-types-anon-const.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
error[E0277]: the size for values of type `T` cannot be known at compilation time | ||
--> $DIR/issue-80062-mismatched-types-anon-const.rs:6:23 | ||
| | ||
LL | fn foo<Foo>() -> Foo { todo!() } | ||
| --- required by this bound in `foo` | ||
LL | | ||
LL | fn bar<T>() { | ||
| - this type parameter needs to be `Sized` | ||
LL | let _: [u8; foo::<T>()]; | ||
| ^ doesn't have a size known at compile-time | ||
| | ||
help: consider relaxing the implicit `Sized` restriction | ||
| | ||
LL | fn foo<Foo: ?Sized>() -> Foo { todo!() } | ||
| ^^^^^^^^ | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/issue-80062-mismatched-types-anon-const.rs:6:17 | ||
| | ||
LL | fn bar<T>() { | ||
| - this type parameter | ||
LL | let _: [u8; foo::<T>()]; | ||
| ^^^^^^^^^^ expected `usize`, found type parameter `T` | ||
| | ||
= note: expected type `usize` | ||
found type parameter `T` | ||
|
||
error[E0277]: the size for values of type `T` cannot be known at compilation time | ||
--> $DIR/issue-80062-mismatched-types-anon-const.rs:6:17 | ||
| | ||
LL | fn bar<T>() { | ||
| - this type parameter needs to be `Sized` | ||
LL | let _: [u8; foo::<T>()]; | ||
| ^^^^^^^^ doesn't have a size known at compile-time | ||
| | ||
= note: the return type of a function must have a statically known size | ||
|
||
error: aborting due to 3 previous errors | ||
|
||
Some errors have detailed explanations: E0277, E0308. | ||
For more information about an error, try `rustc --explain E0277`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems quite subtle, for instance in being sure that
AnonConst
is the only special case. Are there no general methods for doing this (and should there be, if this pattern is used elsewhere)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC a
DefId
can be given to any of the variants ofDefKind
. Maybe closures/generators can cause problems too?