Skip to content

Enable report_in_external_macro in unaligned_references #82587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/rustc_lint_defs/src/builtin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1080,6 +1080,7 @@ declare_lint! {
pub UNALIGNED_REFERENCES,
Allow,
"detects unaligned references to fields of packed structs",
report_in_external_macro
}

declare_lint! {
Expand Down
28 changes: 28 additions & 0 deletions src/test/ui/lint/auxiliary/unaligned_references_external_crate.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#[macro_export]
macro_rules! mac {
(
$(#[$attrs:meta])*
pub struct $ident:ident {
$(
$(#[$pin:ident])?
$field_vis:vis $field:ident: $field_ty:ty
),+ $(,)?
}
) => {
$(#[$attrs])*
pub struct $ident {
$(
$field_vis $field: $field_ty
),+
}

const _: () = {
#[deny(unaligned_references)]
fn __f(this: &$ident) {
$(
let _ = &this.$field;
)+
}
};
};
}
14 changes: 14 additions & 0 deletions src/test/ui/lint/unaligned_references_external_macro.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// aux-build:unaligned_references_external_crate.rs

#![allow(safe_packed_borrows)]

extern crate unaligned_references_external_crate;

unaligned_references_external_crate::mac! { //~ERROR reference to packed field is unaligned
#[repr(packed)]
pub struct X {
pub field: u16
}
}

fn main() {}
26 changes: 26 additions & 0 deletions src/test/ui/lint/unaligned_references_external_macro.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
error: reference to packed field is unaligned
--> $DIR/unaligned_references_external_macro.rs:7:1
|
LL | / unaligned_references_external_crate::mac! {
LL | | #[repr(packed)]
LL | | pub struct X {
LL | | pub field: u16
LL | | }
LL | | }
| |_^
|
note: the lint level is defined here
--> $DIR/unaligned_references_external_macro.rs:7:1
|
LL | / unaligned_references_external_crate::mac! {
LL | | #[repr(packed)]
LL | | pub struct X {
LL | | pub field: u16
LL | | }
LL | | }
| |_^
= note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error