resolve: Partially unify early and late scope-relative identifier resolution #83103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
petrochenkov
added
S-waiting-on-author
petrochenkov
added
S-waiting-on-review
lcnr
approved these changes
Mar 20, 2021
There was a problem hiding this comment.
this looks fairly good to me but I have pretty much no experience with early resolution.
not sure who is more knowledgeable here, maybe
r? @Aaron1011
Aaron1011
reviewed
Mar 27, 2021
Aaron1011
reviewed
Mar 27, 2021
|
r=me with the comment added. |
|
@bors r=Aaron1011 |
|
📌 Commit ee0357a has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse
early_resolve_ident_in_lexical_scopeinstead of a chunk of code inresolve_ident_in_lexical_scopedoing the same job.early_resolve_ident_in_lexical_scope/visit_scopeshad to be slightly extended to be able to 1) start from a specific module instead of the current parent scope and 2) report one deprecation lint.early_resolve_ident_in_lexical_scopestill doesn't support walking through "ribs", that part is left inresolve_ident_in_lexical_scope(moreover, I'm pretty sure it's buggy, but that's a separate issue, cc #52389 at least).