Turn non_fmt_panic into a future_incompatible edition lint. #86671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows supressing the default warning message for future incompatible ints, for lints that already provide a more detailed warning.
rust-highfive
added
the
S-waiting-on-review
m-ou-se
added
A-diagnostics
This was referenced Jun 27, 2021
nikomatsakis
approved these changes
Jun 28, 2021
|
@bors r+ rollup |
|
📌 Commit 934e605 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 28, 2021
…nt, r=nikomatsakis Make disjoint_capture_migration an edition lint. This turns the disjoint capture lint into an edition lint, and changes all the wording to refer to the edition. This includes the same first commit as rust-lang#86671. See rust-lang#86671. Fixes most of rust-lang/project-rfc-2229#43 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#86059 (Add new tool to check HTML) - rust-lang#86529 (Add support for OpenSSL 3.0.0) - rust-lang#86657 (Fix `future_prelude_collision` false positive) - rust-lang#86661 (Editon 2021 enables precise capture) - rust-lang#86671 (Turn non_fmt_panic into a future_incompatible edition lint.) - rust-lang#86673 (Make disjoint_capture_migration an edition lint.) - rust-lang#86678 (Fix garbled suggestion for missing lifetime specifier) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns the
non_fmt_paniclint into a future_incompatible edition lint, so it becomes part of therust_2021_compatibilitygroup. See #85894.This lint produces both warnings about semantical changes (e.g.
panic!("{{")) and things that will become hard errors (e.g.panic!("{")). So I added aexplain_reason: falsethat supresses the default "this will become a hard error" or "the semantics will change" message, and instead added a note depending on the situation. (cc @rylev)r? @nikomatsakis