-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Avoid unnecessary formatting when trace log level is disabled #88934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit e84996b with merge c8bb74fff4c1ac1dcdd0b0c793c15e13c4a5a9e4... |
☀️ Try build successful - checks-actions |
Queued c8bb74fff4c1ac1dcdd0b0c793c15e13c4a5a9e4 with parent ec9a1bd, future comparison URL. |
Finished benchmarking commit (c8bb74fff4c1ac1dcdd0b0c793c15e13c4a5a9e4): comparison url. Summary: This change led to moderate relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r=davidtwco |
📌 Commit e84996b has been approved by |
⌛ Testing commit e84996b with merge 1d417fb0c6def735daa997e8b64c6b7d136adc17... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
This is a known CI failure: #88924 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (38e5764): comparison url. Summary: This change led to very small relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
No description provided.