Skip to content

Avoid unnecessary formatting when trace log level is disabled #88934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Sep 14, 2021

No description provided.

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2021
@jyn514
Copy link
Member

jyn514 commented Sep 14, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Sep 14, 2021

⌛ Trying commit e84996b with merge c8bb74fff4c1ac1dcdd0b0c793c15e13c4a5a9e4...

@bors
Copy link
Collaborator

bors commented Sep 14, 2021

☀️ Try build successful - checks-actions
Build commit: c8bb74fff4c1ac1dcdd0b0c793c15e13c4a5a9e4 (c8bb74fff4c1ac1dcdd0b0c793c15e13c4a5a9e4)

@rust-timer
Copy link
Collaborator

Queued c8bb74fff4c1ac1dcdd0b0c793c15e13c4a5a9e4 with parent ec9a1bd, future comparison URL.

@jyn514 jyn514 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 14, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c8bb74fff4c1ac1dcdd0b0c793c15e13c4a5a9e4): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -1.0% on incr-full builds of derive)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@jyn514
Copy link
Member

jyn514 commented Sep 14, 2021

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Sep 14, 2021

📌 Commit e84996b has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2021
@bors
Copy link
Collaborator

bors commented Sep 15, 2021

⌛ Testing commit e84996b with merge 1d417fb0c6def735daa997e8b64c6b7d136adc17...

@bors
Copy link
Collaborator

bors commented Sep 15, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2021
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[TIMING] Rustc { target: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None }, compiler: Compiler { stage: 1, host: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None } } } -- 0.970
Assembling stage2 compiler (x86_64-pc-windows-msvc)
[TIMING] Sysroot { compiler: Compiler { stage: 2, host: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None } } } -- 0.000
[TIMING] Libdir { compiler: Compiler { stage: 2, host: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None } }, target: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None } } -- 0.000
thread 'main' panicked at 'failed to copy `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\rustc-main.exe` to `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\bin\rustc.exe`: The process cannot access the file because it is being used by another process. (os error 32)', src\bootstrap\lib.rs:1335:17
Build completed unsuccessfully in 0:00:04

@davidtwco
Copy link
Member

This is a known CI failure: #88924

@ehuss
Copy link
Contributor

ehuss commented Sep 15, 2021

@bors retry

#88924

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@bors
Copy link
Collaborator

bors commented Sep 17, 2021

⌛ Testing commit e84996b with merge 38e5764...

@bors
Copy link
Collaborator

bors commented Sep 17, 2021

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 38e5764 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 17, 2021
@bors bors merged commit 38e5764 into rust-lang:master Sep 17, 2021
@tmiasko tmiasko deleted the trace-log branch September 17, 2021 07:09
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (38e5764): comparison url.

Summary: This change led to very small relevant improvements 🎉 in compiler performance.

  • Very small improvement in instruction counts (up to -1.1% on incr-patched: println builds of coercions)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants