Skip to content

revert parts of #89709 (Apply clippy suggestions for rustc and core) to see if it mitigates the perf hit #89855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

matthiaskrgr
Copy link
Member

These looked a bit suspicious to me, requesting a perf run to see if it perhaps fixes the per regression.

cc #89709

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Oct 13, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 13, 2021
@bors
Copy link
Collaborator

bors commented Oct 13, 2021

⌛ Trying commit 9e8aa21 with merge 61da02c924ed7d88f2a2de46122e130218a83430...

@bors
Copy link
Collaborator

bors commented Oct 13, 2021

☀️ Try build successful - checks-actions
Build commit: 61da02c924ed7d88f2a2de46122e130218a83430 (61da02c924ed7d88f2a2de46122e130218a83430)

@rust-timer
Copy link
Collaborator

Queued 61da02c924ed7d88f2a2de46122e130218a83430 with parent eeb16a2, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (61da02c924ed7d88f2a2de46122e130218a83430): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 14, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 14, 2021
@matthiaskrgr matthiaskrgr deleted the rev_89709 branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants