Skip to content

Conversation

@pierwill
Copy link
Contributor

@pierwill pierwill commented Jan 18, 2022

This will make it easier to expand this check to e.g. alloc in the future. (See #92485.)

Also adds some comments to the code, and fixes outdated reference to libcore.

r? @the8472

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2022
@the8472
Copy link
Member

the8472 commented Jan 18, 2022

This doesn't seem to have much value on its own. I mean there's probably some desire to get those comments added to alloc and std but that's a bit larger effort.

Maybe ask the libs team first. If they agree that it's a generally desirable goal then an issue should be created to organize the work and this could be the first commit of several.

@pierwill pierwill closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants