Skip to content

Make Const::val() return a ref, to avoid copies. #94202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make Const::val() return a ref, to avoid copies. #94202

wants to merge 1 commit into from

Conversation

nnethercote
Copy link
Contributor

The idea comes from the last commit of #90951.

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 21, 2022
@nnethercote
Copy link
Contributor Author

I got small wins locally with this, let's see what happens on CI.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 21, 2022
@bors
Copy link
Collaborator

bors commented Feb 21, 2022

⌛ Trying commit 5a858f4b82990b735ecd36f1d6540d00335b45af with merge cd5bb4597008c7ac6ea4149005523abc0955b5e2...

@bors
Copy link
Collaborator

bors commented Feb 21, 2022

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 21, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nnethercote
Copy link
Contributor Author

@bors try

@bors
Copy link
Collaborator

bors commented Feb 21, 2022

⌛ Trying commit a9d3cd1 with merge e93437f564dcb9cd868f5ec5177b53a0a0b7b4e5...

@bors
Copy link
Collaborator

bors commented Feb 21, 2022

☀️ Try build successful - checks-actions
Build commit: e93437f564dcb9cd868f5ec5177b53a0a0b7b4e5 (e93437f564dcb9cd868f5ec5177b53a0a0b7b4e5)

@rust-timer
Copy link
Collaborator

Queued e93437f564dcb9cd868f5ec5177b53a0a0b7b4e5 with parent 026d8ce, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e93437f564dcb9cd868f5ec5177b53a0a0b7b4e5): comparison url.

Summary: This benchmark run did not return any relevant results. 13 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 21, 2022
@nnethercote
Copy link
Contributor Author

Nothing interesting going on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @rust-timer @bors @rust-log-analyzer @rustbot