Skip to content

[EXPERIMENT] Double-check that the load-store approach in 94412 is ok #94497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Mar 1, 2022

Mark suggests in #94412 (comment) that that change wasn't actually a regression, but let's try the other symmetric impl just in case.

r? @ghost

…t a problem

Mark suggests that it wasn't, but I'll make this just to check that copy_nonoverlapping isn't better.
@scottmcm
Copy link
Member Author

scottmcm commented Mar 1, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 1, 2022
@bors
Copy link
Collaborator

bors commented Mar 1, 2022

⌛ Trying commit 14b8e67 with merge 0f5f207ca3e616f6d787c78bbc3994b8677f75c4...

@bors
Copy link
Collaborator

bors commented Mar 1, 2022

☀️ Try build successful - checks-actions
Build commit: 0f5f207ca3e616f6d787c78bbc3994b8677f75c4 (0f5f207ca3e616f6d787c78bbc3994b8677f75c4)

@rust-timer
Copy link
Collaborator

Queued 0f5f207ca3e616f6d787c78bbc3994b8677f75c4 with parent f0c4da4, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0f5f207ca3e616f6d787c78bbc3994b8677f75c4): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 2, 2022
@scottmcm
Copy link
Member Author

scottmcm commented Mar 2, 2022

As expected, not meaningful.

@scottmcm scottmcm closed this Mar 2, 2022
@scottmcm scottmcm deleted the perf-doublecheck branch March 2, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants