Skip to content

cleanup: remove unused ability to have LLVM null-terminate const strings #94638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2022
Merged

cleanup: remove unused ability to have LLVM null-terminate const strings #94638

merged 1 commit into from
Mar 7, 2022

Conversation

erikdesjardins
Copy link
Contributor

@erikdesjardins erikdesjardins commented Mar 5, 2022 •
edited
Loading

(and the copied function in rustc_codegen_gcc)

Noticed this while writing #94450 (comment).

r? @nagisa

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 5, 2022
@rust-highfive
Copy link
Contributor

Some changes occured to rustc_codegen_gcc

cc @antoyo

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2022
@tmiasko
Copy link
Contributor

tmiasko commented Mar 5, 2022 •
edited
Loading

The cstr in existing method name and field name would now suggest that string is always null terminated. What about renaming it, or incorporating into const_str if there are no other users?

nagisa
nagisa approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@nagisa nagisa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed and commits squashed.

@nagisa nagisa added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2022
@tmiasko
Copy link
Contributor

tmiasko commented Mar 6, 2022

@bors r=nagisa

@bors
Copy link
Collaborator

bors commented Mar 6, 2022

📌 Commit e1a4bf6 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2022
@bors
Copy link
Collaborator

bors commented Mar 7, 2022

⌛ Testing commit e1a4bf6 with merge 3d1eaf4...

@bors
Copy link
Collaborator

bors commented Mar 7, 2022

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 3d1eaf4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 7, 2022
@bors bors merged commit 3d1eaf4 into rust-lang:master Mar 7, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 7, 2022
@erikdesjardins erikdesjardins deleted the noextranull branch March 7, 2022 05:54
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3d1eaf4): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 26, 2022
@bors
Auto merge of rust-lang#94638 - erikdesjardins:noextranull, r=nagisa
0e36868 
cleanup: remove unused ability to have LLVM null-terminate const strings

(and the copied function in rustc_codegen_gcc)

Noticed this while writing rust-lang#94450 (comment).

r? `@nagisa`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagisa nagisa nagisa approved these changes

Assignees

@nagisa nagisa

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
7 participants
@erikdesjardins @rust-highfive @tmiasko @bors @rust-timer @nagisa @rustbot