Skip to content

Add newline before stat title in GH summary #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2022
Merged

Add newline before stat title in GH summary #1330

merged 1 commit into from
May 19, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 19, 2022

This is a hotfix for #1322, as it has some weird formatting. Hopefully this fixes it.

@Kobzol Kobzol requested a review from rylev May 19, 2022 08:17
rylev
rylev reviewed May 19, 2022
View reviewed changes
Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if your suggestion or mine is the better way to fix it, thoughts?

(FYI: I manually edited the broken comment linked in this PR)

@Kobzol
Copy link
Contributor Author

Kobzol commented May 19, 2022

I removed the summary heading, changes headers to <h3> (###) and added the newline.

@rylev rylev merged commit 898c46f into master May 19, 2022
@rylev rylev deleted the gh-summary-fix branch May 19, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @rylev