Add token-stream-stress benchmark.
#516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
force-pushed
the
add-token-stream-stress
branch
from
190fd65 to
a85d63d
Compare
|
@Mark-Simulacrum: I have removed the |
|
Will merge once CI verifies this works (it will pass either way, but manual inspection of the log is possible). |
|
Uh, looks like CI actually failed -- probably a trailing comma in the perf config? |
nnethercote
force-pushed
the
add-token-stream-stress
branch
from
a85d63d to
2e3953f
Compare
|
New version, with trailing comma removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent the fix in rust-lang/rust#65198 from regressing.
The benchmark is quite short-running, taking roughly 3x the time of
helloworld. That's more than enough to detect regressions; prior to the fix it would have taken more than 100x longer.@dtolnay, @alexcrichton: this benchmark is based on this test case. I hope that is ok. Let me know if you have ideas on how to improve this.