Skip to content

Add max_width option for all heuristics. #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion Configurations.md
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ fn lorem<Ipsum, Dolor, Sit, Amet>() -> T
Whether to use different formatting for items and expressions if they satisfy a heuristic notion of 'small'.

- **Default value**: `Default`
- **Possible values**: `Default`, `Off`
- **Possible values**: `Default`, `Off`, `Max`
- **Stable**: Yes

#### `Default` (default):
Expand Down Expand Up @@ -337,6 +337,24 @@ fn main() {
}
```

#### `Max`:

```rust
enum Lorem {
Ipsum,
Dolor(bool),
Sit { amet: Consectetur, adipiscing: Elit },
}

fn main() {
lorem("lorem", "ipsum", "dolor", "sit", "amet", "consectetur", "adipiscing");

let lorem = Lorem { ipsum: dolor, sit: amet };

let lorem = if ipsum { dolor } else { sit };
}
```

## `binop_separator`

Where to put a binary operator when a binary expression goes multiline.
Expand Down
3 changes: 3 additions & 0 deletions src/config/config_type.rs
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,9 @@ macro_rules! create_config {
if self.use_small_heuristics.2 == Heuristics::Default {
let max_width = self.max_width.2;
self.set().width_heuristics(WidthHeuristics::scaled(max_width));
} else if self.use_small_heuristics.2 == Heuristics::Max {
let max_width = self.max_width.2;
self.set().width_heuristics(WidthHeuristics::set(max_width));
} else {
self.set().width_heuristics(WidthHeuristics::null());
}
Expand Down
13 changes: 13 additions & 0 deletions src/config/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ configuration_option_enum! { TypeDensity:
configuration_option_enum! { Heuristics:
// Turn off any heuristics
Off,
// Turn on max heuristics
Max,
// Use Rustfmt's defaults
Default,
}
Expand Down Expand Up @@ -257,6 +259,17 @@ impl WidthHeuristics {
}
}

pub fn set(max_width: usize) -> WidthHeuristics {
WidthHeuristics {
fn_call_width: max_width,
struct_lit_width: max_width,
struct_variant_width: max_width,
array_width: max_width,
chain_width: max_width,
single_line_if_else_max_width: max_width,
}
}

// scale the default WidthHeuristics according to max_width
pub fn scaled(max_width: usize) -> WidthHeuristics {
const DEFAULT_MAX_WIDTH: usize = 100;
Expand Down
25 changes: 25 additions & 0 deletions tests/source/configs/use_small_heuristics/max.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// rustfmt-use_small_heuristics: Max

enum Lorem {
Ipsum,
Dolor(bool),
Sit {
amet: Consectetur,
adipiscing: Elit,
},
}

fn main() {
lorem("lorem", "ipsum", "dolor", "sit", "amet", "consectetur", "adipiscing");

let lorem = Lorem {
ipsum: dolor,
sit: amet,
};

let lorem = if ipsum {
dolor
} else {
sit
};
}
15 changes: 15 additions & 0 deletions tests/target/configs/use_small_heuristics/max.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// rustfmt-use_small_heuristics: Max

enum Lorem {
Ipsum,
Dolor(bool),
Sit { amet: Consectetur, adipiscing: Elit },
}

fn main() {
lorem("lorem", "ipsum", "dolor", "sit", "amet", "consectetur", "adipiscing");

let lorem = Lorem { ipsum: dolor, sit: amet };

let lorem = if ipsum { dolor } else { sit };
}