build: Remove *-windows-gnu builds #1917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesuji
force-pushed
the
drop-pc-windows-gnu
branch
2 times, most recently
from
00e6ae7 to
1cbb344
Compare
tesuji
force-pushed
the
drop-pc-windows-gnu
branch
2 times, most recently
from
8645bbf to
8112f97
Compare
|
☔ The latest upstream changes (presumably #1955) made this pull request unmergeable. Please resolve the merge conflicts. |
* Add cache support * Finish all build jobs if one failed
tesuji
force-pushed
the
drop-pc-windows-gnu
branch
from
8112f97 to
3901933
Compare
|
At the time we thought this was the right thing to do -- depending on how Sequoia goes, we might want to switch from defaulting to the MSVC builds to defaulting to the -gnu builds instead, so that we stand a chance of doing GPG verification on Windows. I need to give this more thought. |
|
☔ The latest upstream changes (presumably #2061) made this pull request unmergeable. Please resolve the merge conflicts. |
|
On the basis that we've not made any more movement on this in quite a long time, I suggest we close this. Do you agree? |
|
If we cannot agree about removing windows-gnu builds, let's close it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #1851