Skip to content

Add code coverage #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Add code coverage #641

wants to merge 12 commits into from

Conversation

max-sixty
Copy link
Contributor

@max-sixty
Copy link
Contributor Author

Tests are passing now. Let me know any feedback.

IIUC someone with repo access will need to enable for coveralls in order to see & record the results

@LukeMathWalker
Copy link
Member

Nice!
@jturner314, you enabled codecov for ndarray-stats - should we use the same account for all crates in this organization? Not familiar with the tool 🙌

@termoshtt
Copy link
Member

IIUC someone with repo access will need to enable for coveralls in order to see & record the results

I've sent auth request for coveralls. @jturner314 could you check it?

should we use the same account for all crates in this organization?

I also try to use codecov for ndarray-linalg rust-ndarray/ndarray-linalg#157 (though I still have some trouble about linking issue to LAPACK)

@termoshtt termoshtt mentioned this pull request Jun 21, 2019
Closed
@max-sixty
Copy link
Contributor Author

Just seen #628! Fine to close this when the other merges.

@max-sixty
Copy link
Contributor Author

Closing as stale; not sure whether the code on #628 was ever merged though?

@max-sixty max-sixty closed this Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ci] Add Code Coverage
3 participants
@max-sixty @LukeMathWalker @termoshtt