Skip to content

Travis runs on all branches #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

max-sixty
Copy link
Contributor

Was there a reason to have this filter?

The existing code wouldn't kick off travis runs on my fork's travis (i.e. https://travis-ci.org/max-sixty/ndarray/branches), which I think means I need to create a PR to see a travis run.

The proposed code will kick off a travis run on any branch (on forks which have travis enabled)

But if this was deliberate for some reason then feel free to close

@max-sixty
Copy link
Contributor Author

Gentle reminder on this, lmk any feedback, thanks

@burrbull
Copy link

You can better add trying branch into .travis.yml whitelist. And when you need to test some branch, create copy of it with name trying (like bors-ng do when you call bors try).

@max-sixty
Copy link
Contributor Author

@burrbull What advantage does that have over the proposed changes?

@burrbull
Copy link

This repo has 15 branches and a lot of forks. You want to make travis to build after any change in any branch. It's bad way.

@max-sixty
Copy link
Contributor Author

TBC, this repo's Travis only runs on a change in a fork if that fork has a open PR - it's the other fork's travis that would run on a change.

I maintain https://github.com/pydata/xarray, which has 408 forks, and the proposed model works great. I've never seen the existing model before - is it prevalent?

@LukeMathWalker
Copy link
Member

My understanding is in line with @max-sixty - it will only run on ndarray's Travis when a PR is open. But it will run on the fork CI while you are working on it, before opening a PR.

Unless there is something I am missing, I would go ahead and merge the change after #628 is finalized.

@LukeMathWalker LukeMathWalker merged commit beb537c into rust-ndarray:master Jul 2, 2019
@LukeMathWalker
Copy link
Member

No need to wait in the end, the conflict would be extremely minor.

@max-sixty
Copy link
Contributor Author

Cheers @LukeMathWalker !

@max-sixty max-sixty deleted the travis-master branch July 2, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants