Add error types

src/buffer.rs

@@ -15,11 +15,11 @@ impl<F> ParseableParametrized<[u8], u16> for GenlMessage<F>
 where
     F: ParseableParametrized<[u8], GenlHeader> + Debug,
 {
+    type Error = DecodeError;
     fn parse_with_param(
         buf: &[u8],
         message_type: u16,
     ) -> Result<Self, DecodeError> {
-        let buf = GenlBuffer::new_checked(buf)?;
         Self::parse_with_param(&buf, message_type)
     }
 }
@@ -28,7 +28,9 @@ impl<'a, F, T> ParseableParametrized<GenlBuffer<&'a T>, u16> for GenlMessage<F>
 where
     F: ParseableParametrized<[u8], GenlHeader> + Debug,
     T: AsRef<[u8]> + ?Sized,
+    F::Error: Into<DecodeError>,
 {
+    type Error = DecodeError;
     fn parse_with_param(
         buf: &GenlBuffer<&'a T>,
         message_type: u16,
@@ -37,7 +39,7 @@ where
         let payload_buf = buf.payload();
         Ok(GenlMessage::new(
             header,
-            F::parse_with_param(payload_buf, header)?,
+            F::parse_with_param(payload_buf, header).map_err(|err|err.into())?,
             message_type,
         ))
     }

src/ctrl/mod.rs

@@ -120,6 +120,7 @@ impl Emitable for GenlCtrl {
 }
 
 impl ParseableParametrized<[u8], GenlHeader> for GenlCtrl {
+    type Error = DecodeError;
     fn parse_with_param(
         buf: &[u8],
         header: GenlHeader,
@@ -133,7 +134,7 @@ impl ParseableParametrized<[u8], GenlHeader> for GenlCtrl {
 
 fn parse_ctrlnlas(buf: &[u8]) -> Result<Vec<GenlCtrlAttrs>, DecodeError> {
     let nlas = NlasIterator::new(buf)
-        .map(|nla| nla.and_then(|nla| GenlCtrlAttrs::parse(&nla)))
+        .map(|nla| nla.map_err(|err|DecodeError::Nla(err)).and_then(|nla| GenlCtrlAttrs::parse(&nla)))
         .collect::<Result<Vec<_>, _>>()
         .context("failed to parse control message attributes")?;
 

src/ctrl/nlas/mcast.rs

@@ -95,6 +95,7 @@ impl Nla for McastGrpAttrs {
 impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>>
     for McastGrpAttrs
 {
+    type Error = DecodeError;
     fn parse(buf: &NlaBuffer<&'a T>) -> Result<Self, DecodeError> {
         let payload = buf.value();
         Ok(match buf.kind() {

src/ctrl/nlas/mod.rs

@@ -97,6 +97,7 @@ impl Nla for GenlCtrlAttrs {
 impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>>
     for GenlCtrlAttrs
 {
+    type Error = DecodeError;
     fn parse(buf: &NlaBuffer<&'a T>) -> Result<Self, DecodeError> {
         let payload = buf.value();
         Ok(match buf.kind() {
@@ -123,10 +124,10 @@ impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>>
             CTRL_ATTR_OPS => {
                 let ops = NlasIterator::new(payload)
                     .map(|nlas| {
-                        nlas.and_then(|nlas| {
+                        nlas.map_err(|err|DecodeError::from(err)).and_then(|nlas| {
                             NlasIterator::new(nlas.value())
                                 .map(|nla| {
-                                    nla.and_then(|nla| OpAttrs::parse(&nla))
+                                    nla.map_err(|err|DecodeError::from(err)).and_then(|nla| OpAttrs::parse(&nla))
                                 })
                                 .collect::<Result<Vec<_>, _>>()
                         })
@@ -138,10 +139,10 @@ impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>>
             CTRL_ATTR_MCAST_GROUPS => {
                 let groups = NlasIterator::new(payload)
                     .map(|nlas| {
-                        nlas.and_then(|nlas| {
+                        nlas.map_err(|err|DecodeError::from(err)).and_then(|nlas| {
                             NlasIterator::new(nlas.value())
                                 .map(|nla| {
-                                    nla.and_then(|nla| {
+                                    nla.map_err(|err|DecodeError::from(err)).and_then(|nla| {
                                         McastGrpAttrs::parse(&nla)
                                     })
                                 })

src/ctrl/nlas/oppolicy.rs

@@ -36,10 +36,11 @@ impl Nla for OppolicyAttr {
 }
 
 impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>> for OppolicyAttr {
+    type Error = DecodeError;
     fn parse(buf: &NlaBuffer<&'a T>) -> Result<Self, DecodeError> {
         let payload = buf.value();
         let policy_idx = NlasIterator::new(payload)
-            .map(|nla| nla.and_then(|nla| OppolicyIndexAttr::parse(&nla)))
+            .map(|nla| nla.map_err(|err|DecodeError::from(err)).and_then(|nla| OppolicyIndexAttr::parse(&nla)))
             .collect::<Result<Vec<_>, _>>()
             .context("failed to parse OppolicyAttr")?;
 
@@ -85,6 +86,7 @@ impl Nla for OppolicyIndexAttr {
 impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>>
     for OppolicyIndexAttr
 {
+    type Error = DecodeError;
     fn parse(buf: &NlaBuffer<&'a T>) -> Result<Self, DecodeError> {
         let payload = buf.value();
         Ok(match buf.kind() {

src/ctrl/nlas/ops.rs

@@ -89,6 +89,7 @@ impl Nla for OpAttrs {
 }
 
 impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>> for OpAttrs {
+    type Error = DecodeError;
     fn parse(buf: &NlaBuffer<&'a T>) -> Result<Self, DecodeError> {
         let payload = buf.value();
         Ok(match buf.kind() {

src/ctrl/nlas/policy.rs

@@ -41,6 +41,7 @@ impl Nla for PolicyAttr {
 }
 
 impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>> for PolicyAttr {
+    type Error = DecodeError;
     fn parse(buf: &NlaBuffer<&'a T>) -> Result<Self, DecodeError> {
         let payload = buf.value();
 
@@ -81,10 +82,11 @@ impl Nla for AttributePolicyAttr {
 impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>>
     for AttributePolicyAttr
 {
+    type Error = DecodeError;
     fn parse(buf: &NlaBuffer<&'a T>) -> Result<Self, DecodeError> {
         let payload = buf.value();
         let policies = NlasIterator::new(payload)
-            .map(|nla| nla.and_then(|nla| NlPolicyTypeAttrs::parse(&nla)))
+            .map(|nla| nla.map_err(|err|DecodeError::from(err)).and_then(|nla| NlPolicyTypeAttrs::parse(&nla)))
             .collect::<Result<Vec<_>, _>>()
             .context("failed to parse AttributePolicyAttr")?;
 
@@ -168,6 +170,7 @@ impl Nla for NlPolicyTypeAttrs {
 impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>>
     for NlPolicyTypeAttrs
 {
+    type Error = DecodeError;
     fn parse(buf: &NlaBuffer<&'a T>) -> Result<Self, DecodeError> {
         let payload = buf.value();
         Ok(match buf.kind() {

src/header.rs

@@ -24,6 +24,7 @@ impl Emitable for GenlHeader {
 }
 
 impl<T: AsRef<[u8]>> Parseable<GenlBuffer<T>> for GenlHeader {
+    type Error = DecodeError;
     fn parse(buf: &GenlBuffer<T>) -> Result<Self, DecodeError> {
         Ok(Self {
             cmd: buf.cmd(),

src/message.rs

@@ -165,6 +165,7 @@ where
 impl<F> NetlinkDeserializable for GenlMessage<F>
 where
     F: ParseableParametrized<[u8], GenlHeader> + Debug,
+    F::Error: Into<DecodeError>,
 {
     type Error = DecodeError;
     fn deserialize(