iptun: add support to ipip, ipip6 and ip6ip6 tunnels #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathay4t
force-pushed
the
ff/ipip_support
branch
from
2f4128b to
b3e49c6
Compare
cathay4t
reviewed
Apr 8, 2025
ffmancera
force-pushed
the
ff/ipip_support
branch
from
b3e49c6 to
ddc92e7
Compare
All these tunnels use the IFLA_IPTUN_* netlink API. Therefore, both IFLAN_INFO_KIND "ipip" and "ip6tnl" data is serialized using the IpTunnel struct. Unit tests added. Signed-off-by: Fernando Fernandez Mancera <[email protected]>
ffmancera
force-pushed
the
ff/ipip_support
branch
from
ddc92e7 to
ebd2c35
Compare
cathay4t
requested changes
Apr 30, 2025
| } | ||
|
|
||
| impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>> for InfoIpTunnel { | ||
| fn parse(buf: &NlaBuffer<&'a T>) -> Result<Self, DecodeError> { |
There was a problem hiding this comment.
I think we should do ParseableParametrized with InfoKind as argument because IFLA_IPTUN_FLAGS has different size:
net/ipv6/ip6_tunnel.c
1992: if (data[IFLA_IPTUN_FLAGS])
1993: parms->flags = nla_get_u32(data[IFLA_IPTUN_FLAGS]);
2099: /* IFLA_IPTUN_FLAGS */
2129: nla_put_u32(skb, IFLA_IPTUN_FLAGS, parm->flags) ||
2165: [IFLA_IPTUN_FLAGS] = { .type = NLA_U32 },
net/ipv6/sit.c
1664: /* IFLA_IPTUN_FLAGS */
1704: nla_put_be16(skb, IFLA_IPTUN_FLAGS,
1744: [IFLA_IPTUN_FLAGS] = { .type = NLA_U16 },
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these tunnels use the IFLA_IPTUN_* netlink API. Therefore, both IFLAN_INFO_KIND "ipip" and "ip6tnl" data is serialized using the IpTun struct.
Unit tests added.