API break: link: Changing InfoIpTunnel::CollectMetadata(bool) to CollectMetadata#268
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 68.10% 68.66% +0.55%
==========================================
Files 144 146 +2
Lines 10103 10525 +422
==========================================
+ Hits 6881 7227 +346
- Misses 3222 3298 +76 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the handling of the IFLA_IPTUN_COLLECT_METADATA attribute in IP tunnels to treat it as a zero-length flag. Feedback highlights a correctness issue where serializing CollectMetadata(false) will still send the flag to the kernel, causing it to be interpreted as true. It is recommended to either convert CollectMetadata to a unit variant or add an assertion to prevent silent misconfiguration.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ectMetadata The `IFLA_IPTUN_COLLECT_METADATA` is zero length flag attribute, existence means true. Hence the old code `CollectMetadata(false)` will never take effect. Signed-off-by: Gris Ge <cnfourt@gmail.com>
The
IFLA_IPTUN_COLLECT_METADATAis zero length flag attribute