Implement conversions for IpAddress and MacAddress #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
feature/net-type-conversions
branch
from
9c07b8d to
60b7c64
Compare
nicholasbishop
approved these changes
Mar 9, 2025
phip1611
reviewed
Mar 10, 2025
| @@ -34,3 +34,40 @@ impl IpAddress { | |||
| Self(ip_addr) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@nicholasbishop Is there a reason why this type is not yet in uefi-raw?
There was a problem hiding this comment.
Filed an issue about our IP address types: #1575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core::net::*types.[u8; 6]because most other utilities that consume MAC addresses want that type.Checklist