uefi: Implement safe wrapper for EFI_DISK_INFO_PROTOCOL #1590

seijikun · 2025-03-24T21:16:08Z

Implement safe protocol wrapper for EFI_DISK_INFO_PROTOCOL.

I also added an integration-test that's based on the same disk configuration I did for #1589.

Checklist

Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
Update the changelog (if necessary)

phip1611

LGTM! If I see that correctly, you are using the same disk for integration testing that you also add in #1589 , yes?

seijikun · 2025-03-25T09:43:21Z

If I see that correctly, you are using the same disk for integration testing that you also add in #1589 , yes?

Exactly! In the hope of not producing a merge conflict :D

phip1611 · 2025-03-25T14:30:05Z

Exactly! In the hope of not producing a merge conflict :D

Whatever is merged first; the other PR will be rebased onto it. Then we are good to go

uefi-test-runner/src/proto/media.rs

xtask/src/qemu.rs

phip1611 · 2025-03-26T05:35:58Z

Perfect, thanks for the contribution!

seijikun force-pushed the mr-diskinfo branch 2 times, most recently from 22a1687 to f8aa0bb Compare March 24, 2025 21:21

phip1611 approved these changes Mar 25, 2025

View reviewed changes

phip1611 reviewed Mar 25, 2025

View reviewed changes

uefi-test-runner/src/proto/media.rs Show resolved Hide resolved

phip1611 reviewed Mar 25, 2025

View reviewed changes

uefi-test-runner/src/proto/media.rs Outdated Show resolved Hide resolved

phip1611 reviewed Mar 25, 2025

View reviewed changes

xtask/src/qemu.rs Outdated Show resolved Hide resolved

seijikun force-pushed the mr-diskinfo branch from f8aa0bb to 534a98f Compare March 25, 2025 14:57

uefi: Implement safe wrapper for EFI_DISK_INFO_PROTOCOL

19c4805

seijikun force-pushed the mr-diskinfo branch from 534a98f to 19c4805 Compare March 25, 2025 17:25

phip1611 added this pull request to the merge queue Mar 26, 2025

Merged via the queue into rust-osdev:main with commit 3b17445 Mar 26, 2025
16 checks passed