uefi: Add safe protocol wrapper for EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlignedBuffer is a helper class that manages the livetime of a memory region, allocated using a certain alignment. Like Box, it handles deallocation when the object isn't used anymore.
seijikun
force-pushed
the
mr-nvmept
branch
6 times, most recently
from
ad64eeb to
b03f112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a safe API wrapper for
EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL[52c78312-8edc-4233-98f2-1a1aa5e388a5].Added an integration-test for it.
This contains a copy of the
AlignedBuffercommit from #1589.This uses the iterator/mutable design I suggested here: #1589 (comment) where the iter method only captures the protocol (
NvmePassThru) immutably, but requires you to use the produced element (NvmeNamespace) in a mutable way for meaningful methods likeexecute_command.Checklist