Add safe protocol wrapper for EFI_ATA_PASS_THRU_PROTOCOL #1595
+788
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlignedBuffer is a helper class that manages the livetime of a memory region, allocated using a certain alignment. Like Box, it handles deallocation when the object isn't used anymore.
seijikun
force-pushed
the
mr-atapt
branch
14 times, most recently
from
5d20e04 to
17ff660
Compare
phip1611
reviewed
Mar 28, 2025
| /// Note: This uses the global Rust allocator under the hood. | ||
| #[allow(clippy::len_without_is_empty)] | ||
| #[derive(Debug)] | ||
| pub struct AlignedBuffer { |
There was a problem hiding this comment.
I'm fine with keeping this struct. However, the helpers module is supposed to provide helpers to interact with the outer environment.
Therefore, I see better fit for AlignedBuffer in <uefi>/mem/mod.rs.
Are you fine with keeping the AlignedBuffer struct, @nicholasbishop ?
phip1611
reviewed
Mar 28, 2025
phip1611
reviewed
Mar 28, 2025
phip1611
reviewed
Mar 28, 2025
| }; | ||
| let ata_pt = unsafe { | ||
| // don't open exclusive! That would break other tests | ||
| boot::open_protocol::<AtaPassThru>(params, OpenProtocolAttributes::GetProtocol).unwrap() |
There was a problem hiding this comment.
but why? They do not run concurrently but sequentially
There was a problem hiding this comment.
No idea. Maybe it unloads a driver that's required for later tests when I open it exclusively.
Using open_protocol_exclusive here results in:
[PANIC]: panicked at uefi-test-runner/src/proto/device_path.rs:29:85:
called `Result::unwrap()` on an `Err` value: Error { status: INVALID_PARAMETER, data: () }
phip1611
reviewed
Mar 28, 2025
phip1611
reviewed
Mar 28, 2025
phip1611
requested changes
Mar 28, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a safe API wrapper for
EFI_ATA_PASS_THRU_PROTOCOL[1d3de7f0-0807-424f-aa69-11a54e19a46f].Added an integration-test for it.
This contains a copy of the AlignedBuffer commit from #1589.
This uses the iterator/mutable design I suggested here: #1589 (comment) where the iter method only captures the protocol (
AtaPassThru) immutably, but requires you to use the produced element (AtaDevice) in a mutable way for meaningful methods like execute_command.Checklist