Skip to content

uefi-raw: Add HII_CONFIG_ACCESS and KEYWORD_HANDLER protocol bindings #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seijikun
Copy link
Contributor

@seijikun seijikun commented Jun 4, 2025

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)


use crate::{Char16, Guid, Status, guid};

/// EFI_KEYWORD_HANDLER_PROTOCOL
Copy link
Member

@nicholasbishop nicholasbishop Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found myself confused by naming when looking at this in the spec. It starts out referring to EFI_CONFIG_KEYWORD_HANDLER_PROTOCOL, but then in the parameters of GetData and SetData the type of the This pointer is EFI_KEYWORD_HANDLER_PROTOCOL.

I guess this is just a mistake in the spec? It looks like edk2 sticks with the EFI_CONFIG_KEYWORD_HANDLER_PROTOCOL naming, so (unless I'm missing something, which is very possible) I think the name here should be ConfigKeywordHandlerProtocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants