Skip to content

Conversation

@phip1611
Copy link
Member

@phip1611 phip1611 commented Feb 9, 2026

This is a larger PR improving the handling of struct Time from uefi-raw. On a very high level, we can convert a UEFI time to UNIX UTC Timestamps in nanoseconds and also create it from such a timestamp.

This allows:

  • integration into time libraries on higher-levels
  • PartialOrd
  • elapsed_since(&self, future: &Self) -> Option<Duration> {}

Hints for Reviewers

  • It would make sense to only discuss the higher-level approach here and taking a coarse-grained look onto the commit history
  • I will then split this into more reviewable commits

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 self-assigned this Feb 9, 2026
month += 1;
}

let day = (days + 1) as u8;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo self.validate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant