Simplify-add-new-type #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to be able to customize bacon to test with all features enabled
Modify to include all features and omit jobs that do not apply
Having `::*` makes it easier to accidentally put a value that is not one of the type and have it match anything. (Would still get a warning but this make it an error and make code completion easier)
always derived now so that we can use in production because it reduces will allow for reduction of code repetition
The search key should make it easier to find where in the code needs to be updated and how
Code was converted to being infallible but was still a try_from
This is a slower version but easier to maintain
Eliminate the allocations for strings and just use the static str and a reference to the already allocated string for Other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slower version but easier to maintain