Remove flatpath #81
Merged
Remove flatpath #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-git
force-pushed
the
remove-flatpath
branch
2 times, most recently
from
3339c9b to
941ae9e
Compare
We don't have test for this part of the code so working on that before I can finish
Needed to separate it from the code that deserializes it for testing
Was trying to refactor to remove flat_path but then ran into the fact that we don't have tests for that part of the code. So in the process of adding test but trying to be careful not to hit the leetcode API too much
Do validation initially and store the valid data instead. And instead pass around the valid data.
These need to stay in sync for correctness
This is already set by github by default. See https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
c-git
force-pushed
the
remove-flatpath
branch
from
941ae9e to
f41e67f
Compare
|
please update the pull request description / message |
pawarherschel
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This area of the code had no tests!!!
So most of this PR is restructuring the code so tests could be added.
Decided to use insta to build out the tests.
It works pretty well.
Moved the snapshots into sub folders .
I did trade off performance by converting the response to string before deserializing it into the struct but this allows us to store strings for testing and be closer to how the actual code works.
For problem_metadata I had to move the related structs into a separate module as they had a lot of functionality and it was getting confusing.
There is a lot of repeated code but not sure if it's worth trying to remove the duplication.
I did remove some amount of duplication where if they went out of sync it would cause problems.