Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New #89

Merged
merged 2 commits into from
Aug 25, 2024
Merged

New #89

merged 2 commits into from
Aug 25, 2024

Conversation

Antosser
Copy link
Contributor

Really surprised it worked so well and so fast.
Here's how it looks:
2024-08-24_21-45

@Antosser Antosser linked an issue Aug 24, 2024 that may be closed by this pull request
init command #45
Closed
c-git
c-git requested changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@c-git c-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think.

@c-git
Copy link
Contributor

c-git commented Aug 25, 2024

Should we delete the readme after the project is generated?

@Antosser
Copy link
Contributor Author

Should we delete the readme after the project is generated?

Didn't think of it, but we probably still shouldn't. All the major JS frameworks and evenwasm-pack leave it in

@c-git
Copy link
Contributor

c-git commented Aug 25, 2024

Ok maybe in the future we'll update the readme to make a bit more sense after being copied but for not I think it's fine then.

c-git
c-git approved these changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@c-git c-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go forward with this as is based on your feedback.

@c-git c-git merged commit f0a4a12 into develop Aug 25, 2024
4 checks passed
@c-git c-git deleted the new branch August 25, 2024 15:21
@c-git c-git mentioned this pull request Aug 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-git c-git c-git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

init command
2 participants
@Antosser @c-git